Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MenuItems Responsive #2

Open
haydenlinder opened this issue May 15, 2021 · 1 comment
Open

Make MenuItems Responsive #2

haydenlinder opened this issue May 15, 2021 · 1 comment

Comments

@haydenlinder
Copy link
Owner

haydenlinder commented May 15, 2021 •
edited
Loading

Wrap existing MenuItems component with a SwipableDrawer that can be toggled with a button in the Header component when the screen is smaller than 750px.
@haydenlinder
Copy link
Owner Author

haydenlinder commented May 22, 2021 •
edited
Loading

Implemented button and useMediaQuery. Still needs:

  • Implement SwipableDrawer for small screens only. Make sure that menu closes when item is selected.
  • To improve CLS on small screens, find a way to know ahead of sending response whether screen is small. If so, hide menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@haydenlinder