-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interact with API directly? #1
Comments
Wow, runcible looks amazing. I hate working with the CLI so hard, I had no idea anybody was writing a client library. Very cool stuff. Yeah man, if you're feeling it knock yourself out. My one concern is the inclusion of runcible and its dependencies in the module, from the gemspec:
I don't know if there are established best practices in the puppet world for managing dependencies, but I'm not sure we want to just copy activesupport et al under lib. Thoughts? |
I agree, having gem dependencies on a puppet module is not great. The best thing I've found in the past is what this article describes: http://alcy.github.io/2012/11/21/handling-gem-dependencies-in-custom-puppet-providers/ Installing the runcible gem would fall outside of the module and would be pretty simple. I like this approach as it fits well with the PuppetLabs recommended Roles/Profiles practice. If we do this and the runcible gem is not installed the puppet run will simply say there are no providers and will fail gracefully. I also don't think the absence of the runcible gem would cause a simple pulp server or consumer install to fail. Only something requiring a provider that uses the API would fail. I'll give it a shot and see what happens. |
The tarball does not extract cleanly either manually or through puppet module install. tar zxvf hawknewton-pulp-0.1.0.tar.gz |
So far I'm loving this puppet module. Thanks. As I'm looking for automate more of our Pulp infrastructure I'm finding that the pulp CLI is very limited. For example, I can't use pulp-consumer to see whether a repo has already been bound for the consumer. Because of this I can't add an ensurable repo binding type/provider to this module.
Would you be open to moving certain functionality from using the CLI to using something like Runcible (https://rubygems.org/gems/runcible)? I'm not suggesting a rip and replace of all the commands you have in the providers, but start slowly and especially where the functionality doesn't exist in the CLI. I would be happy to provide a PR to accomplish this.
The text was updated successfully, but these errors were encountered: