Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] save all images referenced while saving helm chart #379

Open
wcrum opened this issue Dec 13, 2024 · 1 comment
Open

[feature] save all images referenced while saving helm chart #379

wcrum opened this issue Dec 13, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@wcrum
Copy link
Contributor

wcrum commented Dec 13, 2024

Is this Feature/Enhancement related to an Existing Problem? If so, please describe:

  • This feature is not related to any existing problem.

Describe Proposed Solution(s):

  • While adding Helm chart to the Hauler, expose a flag such as hauler store add chart [flags] --add-images in which it unpacks and templates base helm chart and add images to image store.

Describe Possible Alternatives:

  • Manually do it?

  • Currently if Hauler users want to save images associated to helm charts they have two first save the helm chart, then download the helm chart separately and try to pull images from the tgz.

# example getting helm chart and images
hauler store add chart hauler-helm --repo oci://ghcr.io/hauler-dev
helm pull oci://ghcr.io/hauler-dev/hauler-helm
helm template hauler hauler-helm-1.1.1.tgz| grep image: | sed -e 's/[ ]*image:[ ]*//' -e 's/"//g' | sort -u
> hauler/hauler-debug:1.1.1
> hauler/hauler:1.1.1
> rancher/kubectl:v1.31.3

Reference: https://stackoverflow.com/questions/60892265/extract-docker-images-from-helm-chart

@wcrum wcrum added the enhancement New feature or request label Dec 13, 2024
@zackbradys zackbradys linked a pull request Dec 14, 2024 that will close this issue
3 tasks
@github-project-automation github-project-automation bot moved this to To Triage in Hauler Jan 16, 2025
@zackbradys zackbradys moved this from To Triage to In Progress in Hauler Jan 16, 2025
@zackbradys
Copy link
Member

hey @wcrum... I'm moving this out of v1.2.0 since the PR was closed. Hope you are able to reopen it and contribute this feature to the project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants