We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github username: -- Twitter username: -- HATS Profile: ---
Beneficiary: 0x3828b7Dff72E340B44f3A0270574dDE9276D5FD3 Submission hash (on-chain): 0x575510d011adfe70300246f105d2f0381e99460cc6528ee5f51d79ffa6d3da91 Severity: low
Description: Invalid error in depositDSS() function
if we check this function in exchange.sol contract:
function depositDSS( uint256 amount, address _tokenAddress ) external onlyOwner { require(IERC20(_tokenAddress).transferFrom(msg.sender, address(this), amount), "Token withdrawal failed"); }
We can see it reverts with error of "Token withdrawal failed" while it should be: "Token deposit failed"
Incorrect error can lead to confusion.
replace it with: "Token deposit failed"
The text was updated successfully, but these errors were encountered:
fixes #28
8f24eeb
@vishal-develop-web Can you please have a look at fixes ?
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
Github username: --
Twitter username: --
HATS Profile: ---
Beneficiary: 0x3828b7Dff72E340B44f3A0270574dDE9276D5FD3
Submission hash (on-chain): 0x575510d011adfe70300246f105d2f0381e99460cc6528ee5f51d79ffa6d3da91
Severity: low
Description:
Invalid error in depositDSS() function
if we check this function in exchange.sol contract:
We can see it reverts with error of "Token withdrawal failed" while it should be:
"Token deposit failed"
Impact
Incorrect error can lead to confusion.
Recommendation
replace it with:
"Token deposit failed"
The text was updated successfully, but these errors were encountered: