Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server: Strict usage of prepared arguments #8792

Closed
Tracked by #8788
plcplc opened this issue Aug 11, 2022 · 1 comment
Closed
Tracked by #8788

Server: Strict usage of prepared arguments #8792

plcplc opened this issue Aug 11, 2022 · 1 comment
Labels
c/server Related to server cockroachdb t/native-dbs

Comments

@plcplc
Copy link
Contributor

plcplc commented Aug 11, 2022 •
edited by sassela
Loading

CockroachDB is sensitive to all prepared query arguments be referenced in the query, Postgres is not. Currently we always pass session variables as a prepared argument, so this is a problem.
@plcplc plcplc mentioned this issue Aug 15, 2022
Closed
24 tasks
@sassela sassela transferred this issue from another repository Aug 15, 2022
@sassela sassela transferred this issue from another repository Aug 15, 2022
@sassela sassela mentioned this issue Aug 15, 2022
Closed
@plcplc plcplc mentioned this issue Aug 18, 2022
Closed
@robertjdominguez robertjdominguez changed the title Strict usage of prepared arguments Server: Strict usage of prepared arguments Aug 25, 2022
@robertjdominguez robertjdominguez added the c/server Related to server label Aug 25, 2022
@sassela
Copy link
Contributor

sassela commented Sep 1, 2022

The CockroachDB team have pushed a fix which will be available from v22.1.7 — we have a Docker image we can use in the meantime to unblock the frontend work 🙌 considering this resolved, but (Hasura team) please reopen if we notice any issues with the CRDB fix

@sassela sassela closed this as completed Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c/server Related to server cockroachdb t/native-dbs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@plcplc @sassela @robertjdominguez