Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration feature toggles set to false aren't setting properly in Grocy #461

Open
marcjay opened this issue Sep 16, 2024 · 6 comments
Open

Comments

@marcjay
Copy link

marcjay commented Sep 16, 2024

Reporting the same issue as #275. It was closed as the issue was stale, but the issue is very much still there.

The PR that was raised at the time by @Nathanlclark seems like the right fix: #276

I noticed it because I have the following set:

tweaks:
  stock_price_tracking: false

However the Stock Overview tab still shows the price information
image

Checking the console, can see that it's '0' which is not falsey
image
image

Copy link

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Oct 17, 2024
@marcjay
Copy link
Author

marcjay commented Oct 17, 2024

Still an issue

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Oct 18, 2024
Copy link

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Nov 18, 2024
@marcjay
Copy link
Author

marcjay commented Nov 18, 2024

@frenck would you consider merging #276 to resolve this?

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Nov 19, 2024
Copy link

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Dec 19, 2024
@marcjay
Copy link
Author

marcjay commented Dec 19, 2024

Not stale

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant