Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic downloading of macos arm (aarch64/M1) hls version #458

Closed
jneira opened this issue Sep 16, 2021 · 2 comments
Closed

Automatic downloading of macos arm (aarch64/M1) hls version #458

jneira opened this issue Sep 16, 2021 · 2 comments
Labels
os: macOS macOS related issues type: enhancement An enhancement to an already existing feature type: setup Issues related with the extension setup, including binaries downloads

Comments

@jneira
Copy link
Member

jneira commented Sep 16, 2021

  • We dont take in account the architecture when looking for hls artifacts
  • A possible approach could be looking for a specific arch and fallback to the default artifact without it
  • We should be able to get the arch where the vscde extension is being used and translate it to a common identifier, ghc, ghcup and cabal uses aarch64
@jneira jneira added os: macOS macOS related issues type: setup Issues related with the extension setup, including binaries downloads labels Sep 16, 2021
@jneira jneira added the type: enhancement An enhancement to an already existing feature label Sep 28, 2021
@jneira jneira changed the title Automatic downloading of macos arm (aarch64) hls version Automatic downloading of macos arm (aarch64/M1) hls version Sep 28, 2021
@arianvp
Copy link

arianvp commented Feb 15, 2022

This is also a problem on linux ARM; where it also seems like the wrong binary is being downloaded causing VSCode to not function at all :(

@goldfirere
Copy link

This bug has been biting me for several weeks -- but I didn't know it! Even if fixing this is hard, would it be at least possible to issue an error to the user letting them know that VSCode won't work properly on ARM?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os: macOS macOS related issues type: enhancement An enhancement to an already existing feature type: setup Issues related with the extension setup, including binaries downloads
Projects
None yet
Development

No branches or pull requests

3 participants