Implicit cradle upper-directory priorities

[lukel97]

This is open to discussion, not really a bug as much as potentially surprising behaviour. Consider the following directory structure:

.
├── cabal
│   ├── A.hs
│   └── cabal.project
├── stack
│   ├── B.hs
│   └── stack.yaml
└── stack.yaml

Inside the cabal and stack folders, there's an ambiguity as to what directory it should pick for the cradle: it can either choose the more local nested one or the stack.yaml in the upper directory.
In the cabal folder:

$ hie-bios cradle cabal/A.hs 
Cradle for "/Users/luke/Desktop/stack-cabal-mix/cabal/A.hs": Cradle {cradleRootDir = "/Users/luke/Desktop/stack-cabal-mix", cradleOptsProg = CradleAction: Stack}

That seems fair enough, it's choosing the more global stack project.
But in the stack folder:

$ hie-bios cradle stack/B.hs
Cradle for "/Users/luke/Desktop/stack-cabal-mix/stack/B.hs": Cradle {cradleRootDir = "/Users/luke/Desktop/stack-cabal-mix/stack", cradleOptsProg = CradleAction: Stack}

It chooses the more local folder!
This isn't a bug but rather just how the implicit cradle search is done:

implicitConfig' :: FilePath -> MaybeT IO (CradleType a, FilePath)
implicitConfig' fp = (\wdir ->
         (Bios (Program $ wdir </> ".hie-bios") Nothing, wdir)) <$> biosWorkDir fp
  --   <|> (Obelisk,) <$> obeliskWorkDir fp
  --   <|> (Bazel,) <$> rulesHaskellWorkDir fp
     <|> (stackExecutable >> (Stack Nothing,) <$> stackWorkDir fp)
     <|> ((Cabal Nothing,) <$> cabalWorkDir fp)


stackWorkDir :: FilePath -> MaybeT IO FilePath
stackWorkDir = findFileUpwards isStack
  where
    isStack name = name == "stack.yaml"

This means that stack will always win over cabal if it can find a stack.yaml in any upwards directory.
What I would have expected would be for both cabal.project and stack.yaml to be searched for in the current directory, before peeking in the parent directories. Thoughts?

[fendor]

I agree, that would be the better behaviour.

[fendor]

This was implemented via #221

EDIT:
Actually that specific behaviour hasn't been changed