Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make workerqueue cancellable if not started already configurable #4297

Open
soulomoon opened this issue Jun 8, 2024 · 0 comments
Open

Make workerqueue cancellable if not started already configurable #4297

soulomoon opened this issue Jun 8, 2024 · 0 comments

Comments

@soulomoon
Copy link
Collaborator

soulomoon commented Jun 8, 2024

          >  it's pretty much identical to having a resource that's guarded by a lock

yes, with a bit different, enqueued actions would not be cancelled even if the thread (enqueue it) is cancelled.

It reminds me of something, we might probably want to limit some of the queue size to 1, so the waiting to enqueue action can be cancelled when we are doing shakeRestart. Then less likely a duplicated action would be run for the sessionLoadQueue
But maybe in another PR, we might need to come up with some design, such as we might need a bit wrapping to do over TQueue and TMVar if we do it this way.

Originally posted by @soulomoon in #4256 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant