Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate a simple cabal cradle if available #3886

Closed
fendor opened this issue Dec 2, 2023 · 4 comments
Closed

Generate a simple cabal cradle if available #3886

fendor opened this issue Dec 2, 2023 · 4 comments
Assignees
Labels

Comments

@fendor
Copy link
Collaborator

fendor commented Dec 2, 2023

Is your enhancement request related to a problem? Please describe.

For a long time, we have been telling users to use

cradle:
  cabal:

if anything fishy is going on with implicit-hie.
Implicit-hie has served its purpose, and will continue to do so for stack cradles, but for cabal, the trivial cradle should work more reliable.

Describe the solution you'd like

If the user uses a cabal version greater than 3.2, then the internally generated cabal cradle should be the trivial one.

Additional context

https://discourse.haskell.org/t/whats-the-current-status-of-hls-cradle-discovery/8254/5

@fendor
Copy link
Collaborator Author

fendor commented Dec 2, 2023

It seems that #3462 may have implemented this behaviour already, so perhaps we can close this issue immediately.

However, it is necessary to be aware of that, as the next release will change the default behaviour of HLS and may break for old cabal versions, iiuc.

@Avi-D-coder
Copy link
Collaborator

Avi-D-coder commented Dec 8, 2023

Any chance stack will be able to generate it's own cradle in the near future?
I have not been following Haskell development like I used too.
I have just been notified of a build error, and I don't do much Haskell these days.
It'd be good to replace my hacky solution for stack too.

@fendor
Copy link
Collaborator Author

fendor commented Dec 9, 2023

Unfortunately, we are currently not closer to any solution for stack

@michaelpj
Copy link
Collaborator

This is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants