-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement codeAction/resolve
for some of our code actions
#3534
Comments
Hey, I am making proposal on "Implement Resolution Methods in HLS" for Summer of Haskell 2023. I am interested in this project. Can you please elaborate me what you want to say on "we'd like to make it as easy as possible for plugin authors to opt in to code action resolution". What I understand is that code completion resolution is in HLS Core and other resolutions like code action, code lenses etc. are in HLS Plugins. |
I'm planning on making a proposal for that, too; looking forward to the competition! |
HLS plugins are not externally loaded, but are really just a code organization system for this repository. Many of them have specific maintainers who just maintain that plugin and don't contribute to the core of HLS. So we want to keep things as easy as possible for them. |
@michaelpj I understood it completely. |
We did this |
LSP allows you to implement
codeAction/resolve
to fill in details of code actions when the user is considering applying them, rather than immediately when the list of code actions is requested. This has two main advantages:Doing this properly would probably mean figuring out a way to make it easy to add support for code action resolution. Many of our code actions come from plugins, we'd like to make it as easy as possible for plugin authors to opt in to code action resolution.
The text was updated successfully, but these errors were encountered: