Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set the number of threads as a tasty option instead of relying on environment variables #3245

Open
michaelpj opened this issue Oct 5, 2022 · 3 comments
Labels
CI Continuous integration Hackathon This issue is suitable for hackathon sessions level: easy The issue is suited for beginners type: enhancement New feature or request

Comments

@michaelpj
Copy link
Collaborator

At the moment we have to set TASTY_NUM_THREADS to 1 otherwise some of the ghcide tests fail, but I think we can just set this in tasty itself using adjustOption. That would make things less error-prone for devs.

@michaelpj michaelpj added type: enhancement New feature or request CI Continuous integration level: easy The issue is suited for beginners labels Oct 5, 2022
@bendo
Copy link
Contributor

bendo commented Oct 9, 2022

Will look at it.

@michaelpj
Copy link
Collaborator Author

Apparently it's awkward to do this correctly but here is a weird way to do it: UnkindPartition/tasty#406 (comment)

@michaelpj michaelpj added the Hackathon This issue is suitable for hackathon sessions label May 1, 2024
@dyniec
Copy link
Contributor

dyniec commented Jun 9, 2024

I don't think mentioned solution works. But if we were to replace testGroup with sequentialTestGroup at every level of a tree we should get desired behavior.
EDIT: it works, I updated PR to use PlusTestOptions approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration Hackathon This issue is suitable for hackathon sessions level: easy The issue is suited for beginners type: enhancement New feature or request
Projects
Development

No branches or pull requests

3 participants