-
-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the rename plugin on single component projects #2804
Comments
/cc @OliverMadine |
I think this is reasonable. The issue is that the plugin currently partially performs renames for multi-component projects. If we enable it for single component projects, I think we need either:
|
Yeah, I think if we could just fail informatively in the unsupported setting, that might be fine. |
Although, to be clear, a package with a test suite is a "multi-component project", right? So would this in practice rule out essentially all users? |
Yes, I think the second option that I listed would be the preferred behaviour then? In the case of a package with a test suite, we would perform the rename within the single-component (i.e. excluding the test suite). We could also warn the user that the rename was only performed across one component (if they are in a multi-component project). |
Currently the rename plugin is disabled (and hence, not linked to the distributed binary) because it doesn't work reliably on multi-component projects (this is not the plugin's fault, but rather HLS / hie-bios).
While there is work being done to address this, it's been almost a year since the plugin was contributed, and we regularly get requests for the functionality. So it would be nice to enable the plugin at least in single component projects.
The text was updated successfully, but these errors were encountered: