Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please, organize GHC 9.2 API changes #2568

Closed
Anton-Latukha opened this issue Jan 6, 2022 · 3 comments
Closed

Please, organize GHC 9.2 API changes #2568

Anton-Latukha opened this issue Jan 6, 2022 · 3 comments
Labels
level: easy The issue is suited for beginners type: enhancement New feature or request

Comments

@Anton-Latukha
Copy link
Collaborator

Anton-Latukha commented Jan 6, 2022 •
edited
Loading

GHC 9.2 still had API organization & changes.

During hard work in #2503 - some of CPP were placed around, #2503 (comment), the organization would be appreciated.

CPP is justified in .ExactPrint modules, since ghc-exactprint has been redesigned in ghc 9.2: the types and programming model are completely different, so much that it doesn't make sense to abstract those differences behind Compat modules.

The rest need to be organized into Compat infrastructure. ghcide's GHC.Compat infrastructure is planned for #2454, so it is a community-useful work.
@Anton-Latukha Anton-Latukha mentioned this issue Jan 6, 2022
Merged
@pepeiborra

This comment has been minimized.

Sign in to view
@Anton-Latukha Anton-Latukha changed the title Please, organize GHC 9.2 API changes into Compat modules Please, organize GHC 9.2 API changes Jan 7, 2022
@Anton-Latukha

This comment has been minimized.

Sign in to view
@July541 July541 mentioned this issue May 15, 2022
Merged
@michaelpj michaelpj added level: easy The issue is suited for beginners and removed old_good first issue labels Jul 13, 2022
@michaelpj
Copy link
Collaborator

Refactoring our CPP would be nice, but this particular thing is not going to get done

@michaelpj michaelpj closed this as not planned Won't fix, can't repro, duplicate, stale Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
level: easy The issue is suited for beginners type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pepeiborra @hasufell @michaelpj @Anton-Latukha