Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky GHCIDE test: Timestamps do not have millisecond (ignored for now) #2115

Closed
Tracked by #2153
isovector opened this issue Aug 20, 2021 · 5 comments · Fixed by #2144
Closed
Tracked by #2153

Flaky GHCIDE test: Timestamps do not have millisecond (ignored for now) #2115

isovector opened this issue Aug 20, 2021 · 5 comments · Fixed by #2144
Labels
component: ghcide type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@isovector
Copy link
Collaborator

Your environment

Output of haskell-language-server --probe-tools or haskell-language-server-wrapper --probe-tools:
CI

Which OS do you use:
Ubuntu latest

Steps to reproduce

CI is flakey. It reproduces itself.

Expected behaviour

Tests should reliably pass.

Actual behaviour

https://github.com/haskell/haskell-language-server/runs/3373456727

ghcide
  Unit
    timestamps have millisecond resolution: FAIL (0.02s)
      test/exe/Main.hs:5677:
      Timestamps do not have millisecond resolution: 10000us

This happens roughly 10% of the time

@anka-213
Copy link
Contributor

Maybe is just luck that makes it work as much as 90% of the time? Would increasing the tolerance to not require millisecond resolution be a solution?

We could modify findResolution_us to return the actual difference in timestamp (t' - t) in order to help diagnose the problem.

@jneira jneira changed the title Flaky GHCIDE test Flaky GHCIDE test: Timestamps do not have millisecond Aug 24, 2021
@jneira jneira added type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. type: testing labels Aug 25, 2021
@mergify mergify bot closed this as completed in #2144 Sep 2, 2021
@jneira
Copy link
Member

jneira commented Sep 3, 2021

@pepeiborra
https://github.com/haskell/haskell-language-server/runs/3504012776?check_suite_focus=true testing #2154

Test suite ghcide-tests: RUNNING...
ghcide
  Unit
    timestamps have millisecond resolution: FAIL (0.03s)
      test/exe/Main.hs:5717:
      Timestamps do not have millisecond resolution: 10000us

😟 reopening just in case

@jneira jneira reopened this Sep 3, 2021
@isovector
Copy link
Collaborator Author

I just hit this too. Definitely still happening.

@jneira
Copy link
Member

jneira commented Sep 14, 2021

Sorry but i am ignoring it with 692a26e to not block ci

@isovector
Copy link
Collaborator Author

Thanks @jneira. I was just about to send a PR doing that

@jneira jneira changed the title Flaky GHCIDE test: Timestamps do not have millisecond Flaky GHCIDE test: Timestamps do not have millisecond (ignored for now) Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ghcide type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants