Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support GHC 8.10.5 #1898

Closed
Ailrun opened this issue Jun 6, 2021 · 7 comments
Closed

Support GHC 8.10.5 #1898

Ailrun opened this issue Jun 6, 2021 · 7 comments
Labels
CI Continuous integration old_type: distribution

Comments

@Ailrun
Copy link
Member

Ailrun commented Jun 6, 2021 •
edited
Loading

GHC 8.10.5 is out, and it fixed the thread-safety issue mentioned in #1863 (comment)~~, so I think now we can replace 8.10.2 with 8.10.5~~.

Unfortunately, we cannot remove 8.10.2 because of https://gitlab.haskell.org/ghc/ghc/-/issues/19968. I will open a separate issue for 8.10.6 support and 8.10.2 removal.
@Ailrun Ailrun mentioned this issue Jun 6, 2021
Merged
@Ailrun
Copy link
Member Author

Ailrun commented Jun 9, 2021

We cannot remove 8.10.2 until 8.10.6 is out, as MacOS has a build problem with GHC 8.10.5

@jneira
Copy link
Member

jneira commented Jun 10, 2021 •
edited
Loading

@Ailrun is there some ghc ticket about the macos problem? it would be great to track it, to ensure 8.10.6 will have a fix for macos

@Ailrun
Copy link
Member Author

Ailrun commented Jun 10, 2021

Here is the link: https://gitlab.haskell.org/ghc/ghc/-/issues/19968

@Ailrun Ailrun changed the title Support GHC 8.10.5 and remove 8.10.2 Support GHC 8.10.5 Jun 12, 2021
@Ailrun Ailrun mentioned this issue Jun 12, 2021
Closed
@Ailrun
Copy link
Member Author

Ailrun commented Jun 12, 2021

Closed by #1899. For the GHC 8.10.2 issue and GHC 8.10.6 support, please see #1913.

@Ailrun Ailrun closed this as completed Jun 12, 2021
@fishtreesugar fishtreesugar mentioned this issue Jun 14, 2021
Closed
@mouse07410
Copy link

Could you clarify, please? It looks like HLS-1.2.0 does not support GHC-8.10.5 on MacOS yet?

Screen Shot 2021-06-15 at 10 44 10

@Ailrun
Copy link
Member Author

Ailrun commented Jun 15, 2021

@mouse07410
From 1.2.0 release note:

@mouse07410
Copy link

mouse07410 commented Jun 15, 2021 •
edited
Loading

macOS version is unfortunately not included in this release because of a GHC issue with network package.

Please see #1913

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous integration old_type: distribution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jneira @mouse07410 @Ailrun