Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package plugin (adding dependencies into .cabal and package.yaml files) #155

Open
jneira opened this issue Jun 12, 2020 · 3 comments
Open
Labels
type: enhancement New feature or request

Comments

@jneira
Copy link
Member

jneira commented Jun 12, 2020

Add a package to your project with a handy code-action!

@fendor fendor changed the title Package plugin (adding dependencies auto into .cabal and package.yaml files) Package plugin (adding dependencies into .cabal and package.yaml files) Jun 12, 2020
@fendor fendor mentioned this issue Jun 12, 2020
@lukel97
Copy link
Collaborator

lukel97 commented Jul 13, 2020

I don't think the plugin should be ported directly, as it was pretty hairy in HIE. I remember when writing it it was really destructive to .cabal files' formatting as there doesn't exist a round-trip parser. Which made it pretty useless in practice. The package.yaml part though I think could be rewritten with a roundtrip yaml parser, thanks to a GSoC project on HsYAML: https://hackage.haskell.org/package/HsYAML

@domenkozar
Copy link
Contributor

I don't think the plugin should be ported directly, as it was pretty hairy in HIE. I remember when writing it it was really destructive to .cabal files' formatting as there doesn't exist a round-trip parser. Which made it pretty useless in practice. The package.yaml part though I think could be rewritten with a roundtrip yaml parser, thanks to a GSoC project on HsYAML: https://hackage.haskell.org/package/HsYAML

I'd still prefer that over nothing :)

@jneira
Copy link
Member Author

jneira commented Jun 17, 2021

This could be related with #183 (the cabal part), as both would be interface with cabal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants