Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeLens to add type signature inserts invalid type signature #1468

Closed
berberman opened this issue Mar 1, 2021 · 0 comments · Fixed by #1491
Closed

CodeLens to add type signature inserts invalid type signature #1468

berberman opened this issue Mar 1, 2021 · 0 comments · Fixed by #1491
Labels
component: ghcide component: ghcide-type-lenses type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@berberman
Copy link
Collaborator

Your environment

Output of haskell-language-server --probe-tools or haskell-language-server-wrapper --probe-tools:

haskell-language-server version: 1.0.0.0 (GHC: 8.10.3) (PATH: /home/berberman/.cabal/store/ghc-8.10.3/haskell-language-server-1.0.0.0-c7859e8f45ef6bd2fac7adc65982f4e497ee3c40299bcc89c5915aaa0534ebc3/bin/haskell-language-server)
Tool versions found on the $PATH
cabal:          3.2.0.0
stack:          Not found
ghc:            8.10.3

Which lsp-client do you use:
vscode

Steps to reproduce

Create a module with functions that lead to ambiguity:

module Test where

head = 233

(+) = undefined

Expected behaviour

module Test where

head :: Integer
head = 233

(+) :: a
(+) = undefined

Actual behaviour

Type signatures are qualified with the module name, which are invalid.

module Test where

Test.head :: Integer
head = 233

(Test.+) :: a
(+) = undefined
@berberman berberman added type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. component: ghcide labels Mar 1, 2021
@mergify mergify bot closed this as completed in #1491 Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ghcide component: ghcide-type-lenses type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
1 participant