Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghcide 0.7.4.0 breaks hls-explicit-imports-plugin 0.1.0.0 #1332

Closed
hamishmack opened this issue Feb 9, 2021 · 2 comments · Fixed by #1333
Closed

ghcide 0.7.4.0 breaks hls-explicit-imports-plugin 0.1.0.0 #1332

hamishmack opened this issue Feb 9, 2021 · 2 comments · Fixed by #1333
Labels
CI Continuous integration type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@hamishmack
Copy link

Ironically explicitly importing from import Development.IDE.GHC.Compat might have avoided the problem.

src/Ide/Plugin/ExplicitImports.hs:219:10: error:
    Ambiguous occurrence ‘isQualifiedImport’
    It could refer to
       either ‘Development.IDE.GHC.Compat.isQualifiedImport’,
              imported from ‘Development.IDE.GHC.Compat’ at src/Ide/Plugin/ExplicitImports.hs:29:1-33
           or ‘Ide.Plugin.ExplicitImports.isQualifiedImport’,
              defined at src/Ide/Plugin/ExplicitImports.hs:255:1
    |
219 |   | not (isQualifiedImport imp),
    |          ^^^^^^^^^^^^^^^^^
@jneira jneira added CI Continuous integration type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. labels Feb 9, 2021
@jneira
Copy link
Member

jneira commented Feb 9, 2021

Ouch, the plugin need a revision with a upper bound over ghcide then, thanks for noting it
//cc @pepeiborra

@pepeiborra
Copy link
Collaborator

Yeah, I discovered the same thing overnight. Revision done and will upload a new version soon. I have also added @jneira as a maintainer to all my plugins in case I'm not around next time. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants