Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended Eval Plugin: we need more precise handling of :setting flags #1278

Closed
konn opened this issue Jan 31, 2021 · 0 comments · Fixed by #1343
Closed

Extended Eval Plugin: we need more precise handling of :setting flags #1278

konn opened this issue Jan 31, 2021 · 0 comments · Fixed by #1343
Labels
component: hls-eval-plugin type: enhancement New feature or request

Comments

@konn
Copy link
Collaborator

konn commented Jan 31, 2021 •
edited
Loading

As discussed in #1232, the current implementation of :set command in Eval Plugin is somewhat ad-hoc, and several extensions involving digits (such as Rank2Types) are rejected and there is no support of other style flags, such as -fprint-explicit-foralls.

We can use parseDynamicFlagsCmdLine to remedy this situation and comply with the spec of flags used in GHC.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: hls-eval-plugin type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Eval Plugin: Proper handling of flags in :set haskell/haskell-language-server
1 participant
@konn