Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failures with mtl-2.3 #236

Closed
sjakobi opened this issue May 8, 2022 · 7 comments
Closed

Build failures with mtl-2.3 #236

sjakobi opened this issue May 8, 2022 · 7 comments
Assignees
Labels
build failure happy fails to build

Comments

@sjakobi
Copy link
Member

sjakobi commented May 8, 2022

src/ParamRules.hs:31:17: error:
    Not in scope: type constructor or class ‘ExceptT’
   |
31 | type M2       = ExceptT String M1
   |                 ^^^^^^^

src/ParamRules.hs:71:10: error:
    Not in scope: type constructor or class ‘ExceptT’
   |
71 | runM2 :: ExceptT e (Writer w) a -> Either e (a, w)
   |          ^^^^^^^

On Hackage, v1.19.9 to v1.20.0 are affected.

As a Hackage trustee I have created revisions for these versions that should prevent users from encountering these errors. See e.g. https://hackage.haskell.org/package/happy-1.20.0/revisions/.

@andreasabel
Copy link
Member

I believe ExceptT was dropped by mistake:

I expect a fix of mtl-2.3 to be rolled out and mtl-2.3 being deprecated.

@ysangkok
Copy link
Member

ysangkok commented Nov 2, 2022

@andreasabel A fixed mtl-2.3.1 was released. Does this mean happy v1.21 could be revised to allow mtl-2.3.1?

@andreasabel
Copy link
Member

@andreasabel A fixed mtl-2.3.1 was released. Does this mean happy v1.21 could be revised to allow mtl-2.3.1?

I suppose so, but @Ericson2314 is in charge.
I think 1.21 was deprecated because of build failures unrelated to mtl-2.3. So I take your "revised" not as technical term for "Hackage revision", but something including code changes and a release.

@andreasabel
Copy link
Member

@Ericson2314 : Now with GHC 9.6 shipping mtl-2.3.1, it would be good to have a happy release that builds with mtl-2.3.1.
A revision would not suffice because the code needs a change:

Building executable 'happy' for happy-1.20.0
...
src/Grammar.lhs:470:27: error: [GHC-88464]
    Variable not in scope: when :: Bool -> M () -> b
    |
470 | >          checkArity x = when (x > arity) $ addErr (show x++" out of range")
    |                           ^^^^

@andreasabel andreasabel added the build failure happy fails to build label Jan 18, 2023
@andreasabel
Copy link
Member

@Ericson2314: How about releasing a 1.20.1 that just fixes the build with mtl-2.3.1? This could be done rather quickly, branching of the v1.20.0 tag, I suppose.

@andreasabel
Copy link
Member

@andreasabel
Copy link
Member

Fixed in happy-1.20.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build failure happy fails to build
Projects
None yet
Development

No branches or pull requests

3 participants