Add Syntax highglighting for package pages #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This is useful because that way you can ingest single packages
|
Unfortunately, GitHub seems to have trouble so I cannot upload a screenshot. I will do that later. |
before
|
|
I added theme awareness and chose themes that fit hackage-server as it is now better: light
dark
alternate light theme
|
- use jsdelivr to source prismjs (already used for maths) - change radius of pre html element to 3px (same as for search box) - dynamically load language highlighting as required - load solarized light as the light theme and tomorrow night as the dark theme
MangoIV
force-pushed
the
mangoiv/syntax-highlighting
branch
from
cbb81f3
to
611bc5f
Compare
|
base download (without any syntax highlighted) is 10kb and then for haskell syntax highlighting another 2kb. It is only triggered if the package has a README. |
gbaz
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use prism.js to add syntax highlighting to package pages.
Justification: