Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream things from hls-2 #872

Closed
5 of 8 tasks
ndmitchell opened this issue Jun 23, 2020 · 3 comments · Fixed by haskell/ghcide#784
Closed
5 of 8 tasks

Upstream things from hls-2 #872

ndmitchell opened this issue Jun 23, 2020 · 3 comments · Fixed by haskell/ghcide#784

Comments

@ndmitchell
Copy link
Collaborator

The hls-2 branch is ghcide head plus some changes intended to be upstreamed. As per #173, it seems once they are upstreamed hls can use ghcide master. These changes aren't too major, they mainly consist of

The hiedb changes are not included because I don't think they are ready yet.

Taken from a list by @wz1000 in #173 (comment)

@pepeiborra
Copy link
Collaborator

I think we also need to review whether .hie files should be cached in the Shake graph, seeing as more things are using them

@wz1000
Copy link
Collaborator

wz1000 commented Jun 23, 2020

@pepeiborra they are in hls-2

@alanz alanz pinned this issue Sep 2, 2020
@jneira
Copy link
Member

jneira commented Sep 16, 2020

I guess some of the checks are already done, and hls is in hls-3 instead hls-2

@jneira jneira unpinned this issue Sep 27, 2020
@pepeiborra pepeiborra transferred this issue from haskell/ghcide Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants