Document extra-packages a bit better and clean up related entries (closes #5448) #8535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffaf1
reviewed
Oct 15, 2022
ffaf1
reviewed
Oct 15, 2022
ffaf1
reviewed
Oct 15, 2022
| should be considered local packages.` (Not implemented) | ||
| Specifies a list of external packages from Hackage, which | ||
| should be considered local packages. The motivation for | ||
| :cfg-field:`extra-packages` is making libraries that are not |
There was a problem hiding this comment.
Is this one possible motivation or the motivation?
There was a problem hiding this comment.
Taken straight from the horse's mouth:
#3737 (comment)
I imagine there are other uses, but I don't know.
"A common use case" would be an alternative.
jneira
approved these changes
Oct 16, 2022
3 tasks
|
@linearray: thanks a lot for the docs improvement. BTW, we normally use the https://github.com/haskell/cabal/blob/master/CONTRIBUTING.md#github-pull-request-conventions Please give it a try next time, it's pretty handy. :) |
alexbiehl
pushed a commit
to alexbiehl/cabal
that referenced
this pull request
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review carefully, I have never used any of these and only documented them in the way it makes sense to me, which is not necessarily the correct one.
closes #5448
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!