Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NamedAlgo typeclass seems redundant #251

Closed
sorki opened this issue Nov 22, 2023 · 0 comments · Fixed by #291 · May be fixed by haskell-nix/hnix#1112
Closed

NamedAlgo typeclass seems redundant #251

sorki opened this issue Nov 22, 2023 · 0 comments · Fixed by #291 · May be fixed by haskell-nix/hnix#1112
Labels
good first issue

Comments

@sorki
Copy link
Member

sorki commented Nov 22, 2023

7186850 added HashAlgo GADT and ce0b360 added DSum HashAlgo Digest which seems to make NamedAlgo obsolete/redundant.

It is used only at couple of places makeStorePath and makeFixedOutputPath in -readonlys System.Nix.Store.ReadOnly and addToStore in -remote.

Consider replacing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
1 participant
@sorki