Make buildable with ghc 9.8 #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes. Unfortunate news is that I don't have Hackage permissions for |
|
Also at this point it would make sense to allow GHC-9.8 as well. |
blackgnezdo
added a commit
to blackgnezdo/ports
that referenced
this pull request
Nov 10, 2023
Still broken wrt paths untrusted bug: haskell-hvr/paths#16
blackgnezdo
added a commit
to blackgnezdo/ports
that referenced
this pull request
Nov 10, 2023
Still broken wrt paths untrusted bug: haskell-hvr/paths#16
blackgnezdo
added a commit
to blackgnezdo/ports
that referenced
this pull request
Nov 10, 2023
Still broken wrt paths untrusted bug: haskell-hvr/paths#16
blackgnezdo
added a commit
to blackgnezdo/ports
that referenced
this pull request
Nov 11, 2023
Still broken wrt paths untrusted bug: haskell-hvr/paths#16
Done |
Our hand is forced by directory:
src/System/Path/Internal.hs:74:1: error: [GHC-44360]
System.Directory: Can't be safely imported!
The module itself isn't safe.
|
74 | import qualified System.Directory as Dir
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
blackgnezdo
added a commit
to blackgnezdo/ports
that referenced
this pull request
Dec 10, 2023
Workaround is required until upstream releases: haskell-hvr/paths#16
bob-beck
pushed a commit
to openbsd/ports
that referenced
this pull request
Dec 12, 2023
Workaround is required until upstream releases: haskell-hvr/paths#16 OK kili@
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm very uncertain about why we need the Trustworthy commit. GHC is complaining for no reason I can discern. The directory module doesn't have an explicit declaration, so maybe one of its imports changed its inferred status?