From 0822a684afaf2d9d5c86fd147890186da1d9414c Mon Sep 17 00:00:00 2001
From: German Zhyvotnikov <german.zhyvotnikov@zoominsoftware.com>
Date: Mon, 27 Feb 2023 22:41:34 +0200
Subject: [PATCH 1/3] task: add test cases for decoding escaped input

Test case `escapedMalformed0` is failing, throwing uncaught `error`
---
 tests/UnitTests.hs | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/tests/UnitTests.hs b/tests/UnitTests.hs
index 4e625e0..ee2c975 100644
--- a/tests/UnitTests.hs
+++ b/tests/UnitTests.hs
@@ -21,6 +21,7 @@ import qualified Data.Text as T
 import qualified Data.Text.Lazy as LT
 import qualified Data.Vector as V
 import qualified Data.Foldable as F
+import Data.List (isPrefixOf)
 import Data.Word
 import Numeric.Natural
 import GHC.Generics (Generic)
@@ -56,6 +57,14 @@ assertResult input expected res = case res of
                 "      input: " ++ show (BL8.unpack input) ++ "\n" ++
                 "parse error: " ++ err
 
+decodeFailsWith :: BL.ByteString -> String -> Assertion
+decodeFailsWith input expected = case decode NoHeader input of
+    Right r  -> assertFailure $ "input: " ++ show (BL8.unpack input) ++ "\n" ++
+                "retuned: " ++ show (r :: (V.Vector (V.Vector B.ByteString))) ++ "\n" ++
+                "whereas should have failed with " <> expected
+    Left err -> assertBool ("got " <> err <> "\ninstead of " <> expected)
+                $ ("parse error ("++expected++")") `isPrefixOf` err
+
 encodesAs :: [[B.ByteString]] -> BL.ByteString -> Assertion
 encodesAs input expected =
     encode (map V.fromList input) @?= expected
@@ -166,6 +175,7 @@ positionalTests =
       [ testGroup "decode" $ map streamingDecodeTest decodeTests
       , testGroup "decodeWith" $ map streamingDecodeWithTest decodeWithTests
       ]
+    , testGroup "escaped" escapedTests
     ]
   where
     rfc4180Input = BL8.pack $
@@ -210,6 +220,15 @@ positionalTests =
     defEncAllEnq  = defaultEncodeOptions { encQuoting = QuoteAll  }
     defDec = defaultDecodeOptions
 
+    escapedTests = [
+      testCase "escaped" $
+        "\"x,y\",z\nbaz,\"bar\nfoo,\"" `decodesAs` [["x,y", "z"], ["baz", "bar\nfoo,"]],
+      testCase "escapedMalformed1" $
+        "\"x,\"y" `decodeFailsWith` "endOfInput",
+      testCase "escapedMalformed0" $
+        "baz,\"" `decodeFailsWith` "endOfInput"
+      ]
+
 nameBasedTests :: [TF.Test]
 nameBasedTests =
     [ testGroup "encode" $ map encodeTest

From a4627a6fb4ee9ce91134cdedec2263cf3651ef46 Mon Sep 17 00:00:00 2001
From: German Zhyvotnikov <german.zhyvotnikov@zoominsoftware.com>
Date: Mon, 27 Feb 2023 23:23:02 +0200
Subject: [PATCH 2/3] fix: handle case when input for field parser is a single
 opening double-quote

---
 src/Data/Csv/Parser.hs | 25 ++++++++++++++-----------
 tests/UnitTests.hs     |  2 +-
 2 files changed, 15 insertions(+), 12 deletions(-)

diff --git a/src/Data/Csv/Parser.hs b/src/Data/Csv/Parser.hs
index d028167..82fe4d2 100644
--- a/src/Data/Csv/Parser.hs
+++ b/src/Data/Csv/Parser.hs
@@ -154,17 +154,20 @@ field !delim = do
 escapedField :: AL.Parser S.ByteString
 escapedField = do
     _ <- dquote
-    -- The scan state is 'True' if the previous character was a double
-    -- quote.  We need to drop a trailing double quote left by scan.
-    s <- S.init <$> (A.scan False $ \s c -> if c == doubleQuote
-                                            then Just (not s)
-                                            else if s then Nothing
-                                                 else Just False)
-    if doubleQuote `S.elem` s
-        then case Z.parse unescape s of
-            Right r  -> return r
-            Left err -> fail err
-        else return s
+    -- The scan state is 'True' if the previous character was a double quote.
+    s' <- A.scan False $ \s c -> if c == doubleQuote
+                                 then Just (not s)
+                                 else if s then Nothing
+                                      else Just False
+    -- We need to drop a trailing double quote left by scan.
+    if S.null s'
+      then fail "trailing double quote"
+      else let s = S.init s'
+           in if doubleQuote `S.elem` s
+              then case Z.parse unescape s of
+                     Right r  -> return r
+                     Left err -> fail err
+              else return s
 
 unescapedField :: Word8 -> AL.Parser S.ByteString
 unescapedField !delim = A.takeWhile (\ c -> c /= doubleQuote &&
diff --git a/tests/UnitTests.hs b/tests/UnitTests.hs
index ee2c975..2bf35fa 100644
--- a/tests/UnitTests.hs
+++ b/tests/UnitTests.hs
@@ -226,7 +226,7 @@ positionalTests =
       testCase "escapedMalformed1" $
         "\"x,\"y" `decodeFailsWith` "endOfInput",
       testCase "escapedMalformed0" $
-        "baz,\"" `decodeFailsWith` "endOfInput"
+        "baz,\"" `decodeFailsWith` "Failed reading: trailing double quote"
       ]
 
 nameBasedTests :: [TF.Test]

From c7bdbcae8701367ced93588711295d6c4fa82187 Mon Sep 17 00:00:00 2001
From: Yitz Gale <yitz.gale@zoominsoftware.com>
Date: Wed, 3 Jan 2024 18:49:42 +0200
Subject: [PATCH 3/3] Fix output of escapedMalformed1 test

---
 tests/UnitTests.hs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/UnitTests.hs b/tests/UnitTests.hs
index 2bf35fa..12ea362 100644
--- a/tests/UnitTests.hs
+++ b/tests/UnitTests.hs
@@ -224,7 +224,7 @@ positionalTests =
       testCase "escaped" $
         "\"x,y\",z\nbaz,\"bar\nfoo,\"" `decodesAs` [["x,y", "z"], ["baz", "bar\nfoo,"]],
       testCase "escapedMalformed1" $
-        "\"x,\"y" `decodeFailsWith` "endOfInput",
+        "\"x,\"y" `decodeFailsWith` "Failed reading: satisfy",
       testCase "escapedMalformed0" $
         "baz,\"" `decodeFailsWith` "Failed reading: trailing double quote"
       ]