Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have make_travis_yml_2.hs test that Haddocks build #76

Closed
seagreen opened this issue Mar 27, 2017 · 4 comments
Closed

Have make_travis_yml_2.hs test that Haddocks build #76

seagreen opened this issue Mar 27, 2017 · 4 comments

Comments

@seagreen
Copy link

"Check for 100% Haddock coverage" is currently listed in the Additional Checks section, but a smaller check that everyone would probably want would be just making sure the Haddocks build.

@hvr
Copy link
Member

hvr commented Mar 28, 2017

That's a good idea; I'm just waiting for cabal new-haddock to become a bit more reliable. But you could experiment yourself by trying to insert an invocation of cabal new-haddock in the generated .travis.yml scripts and report back how well it works for you. Maybe it's already good enough so that we can enable it for everybody.

@seagreen
Copy link
Author

I tested out cabal new-haddock and it works great. I've got it added on hjsonschema's master now so if any problems do come up I'll let you know.

@hvr
Copy link
Member

hvr commented May 17, 2017

note to myself: need to workaround haskell/cabal#4506

@phadej
Copy link
Collaborator

phadej commented Dec 15, 2017

new--haddock is in the v2 script

@phadej phadej closed this as completed Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants