Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit listing with format json returns json, not a string #6776

Merged
merged 3 commits into from
Jun 4, 2019

Conversation

jefferai
Copy link
Member

Fixes #6775

@jefferai jefferai added this to the 1.1.3 milestone May 22, 2019
briankassouf
briankassouf previously approved these changes May 22, 2019
michelvocks
michelvocks previously approved these changes May 23, 2019
Copy link
Contributor

@michelvocks michelvocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should fix this also for other commands e.g. vault kv list vault namespace list

@jefferai
Copy link
Member Author

Sure, feel free to edit the branch and push more up to this PR.

@michelvocks michelvocks dismissed stale reviews from briankassouf and themself via b1fe911 May 24, 2019 06:54
command/audit_list.go Outdated Show resolved Hide resolved
@briankassouf briankassouf merged commit 72cb483 into master Jun 4, 2019
@briankassouf briankassouf deleted the issue-6775 branch June 4, 2019 17:36
briankassouf pushed a commit that referenced this pull request Jun 4, 2019
* Audit listing with format json returns json, not a string

Fixes #6775

* list, kv list and namespace list with format json returns json, not a string

* Changed audit list return code to 2 which aligns with other list commands return codes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vault audit list -format json does not return JSON when list is empty
3 participants