VAULT-31755: Add removed and HA health to the sys/health endpoint #28991
+351
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
6 tasks
kubawi
approved these changes
Nov 28, 2024
Comment on lines
+119
to
+136
| // Partition forces the inmem layer to disconnect itself from peers and prevents | ||
| // creating new connections. The returned function will add all peers back | ||
| // and re-enable connections | ||
| func (l *InmemLayer) Partition() (unpartition func()) { | ||
| l.l.Lock() | ||
| peersCopy := make([]*InmemLayer, 0, len(l.peers)) | ||
| for _, peer := range l.peers { | ||
| peersCopy = append(peersCopy, peer) | ||
| } | ||
| l.l.Unlock() | ||
| l.DisconnectAll() | ||
| return func() { | ||
| for _, peer := range peersCopy { | ||
| l.Connect(peer) | ||
| } | ||
| } | ||
| } | ||
|
|
| @@ -977,6 +977,10 @@ func (c *TestClusterCore) ClusterListener() *cluster.Listener { | |||
| return c.getClusterListener() | |||
| } | |||
|
|
|||
| func (c *TestClusterCore) NetworkLayer() cluster.NetworkLayer { | |||
There was a problem hiding this comment.
Hey, I made an identical getter function in a yet-unmerged PR, and wrote this comment out, so I figured I might as well suggest the godoc here 😄
I know that the function itself is super simple, but our overall test cluster machinery is complex, so I think it's nice to clarify intent behind any exported functions for future devs, etc. Feel free to discard this if it's over the top.
Suggested change
| func (c *TestClusterCore) NetworkLayer() cluster.NetworkLayer { | |
| // NetworkLayer returns the network layer for the cluster core. This can be used | |
| // in conjunction with the cluster.InmemLayer to disconnect specific nodes from | |
| // the cluster when we need to simulate abrupt node failure or a network | |
| // partition in NewTestCluster tests. | |
| func (c *TestClusterCore) NetworkLayer() cluster.NetworkLayer { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds HA health and removed as statuses to the sys/health endpoint.
removedcodequery parameter)haunhealthycodequery parameter)The health response has new fields:
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.