Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug setting PKI issuer enable_aia_url_templating to be set to false #28832

Merged

Conversation

victorr
Copy link
Contributor

@victorr victorr commented Nov 4, 2024

Description

Fix bug setting PKI issuer enable_aia_url_templating to be set to false.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@victorr victorr added backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/1.18.x backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent labels Nov 4, 2024
@victorr victorr added this to the 1.18.2 milestone Nov 4, 2024
@victorr victorr self-assigned this Nov 4, 2024
@victorr victorr requested a review from a team as a code owner November 4, 2024 20:32
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Nov 4, 2024
@victorr victorr force-pushed the victorr/vault-32137-fix-issuer-patch-enable-templating branch from 1d55975 to d21c82c Compare November 4, 2024 20:34
Copy link

github-actions bot commented Nov 4, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Nov 4, 2024

Build Results:
All builds succeeded! ✅

@victorr victorr requested a review from kitography November 4, 2024 20:36
Copy link
Contributor

@kitography kitography left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me

@victorr victorr enabled auto-merge (squash) November 4, 2024 20:42
@victorr victorr merged commit c855f6e into main Nov 4, 2024
91 checks passed
@victorr victorr deleted the victorr/vault-32137-fix-issuer-patch-enable-templating branch November 4, 2024 20:51
victorr added a commit that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent backport/1.18.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants