Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support trimming trailing slashes via a mount tuneable to support CMPv2 #28752

Merged
merged 20 commits into from
Oct 24, 2024

Conversation

sgmiller
Copy link
Collaborator

Description

CMPv2 specifies that the cmp path may or may not end in a trailing slash.
Vault's request processing has a requirement that they do not for POST. To
make this work, add a tuneable to the mount that will trim slashes if
enabled. All existing mounts will default to off, preserving the existing
behavior. CMPv2 capable PKI mounts will enable this.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@sgmiller sgmiller requested a review from a team as a code owner October 23, 2024 17:05
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 23, 2024
Copy link

github-actions bot commented Oct 23, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Oct 23, 2024

Build Results:
All builds succeeded! ✅

@sgmiller sgmiller added this to the 1.19.0-rc milestone Oct 23, 2024
@sgmiller sgmiller requested a review from a team as a code owner October 23, 2024 18:58
vault/router.go Outdated Show resolved Hide resolved
vault/logical_system.go Outdated Show resolved Hide resolved
command/auth_tune.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.18.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants