Add auto-roll billing start date changes CE changes #27656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
mpalmi
reviewed
Jul 2, 2024
mpalmi
approved these changes
Jul 2, 2024
I reverted those changes on the ent PR we can use core.BillingStart now https://github.com/hashicorp/vault-enterprise/pull/5681/commits/9ddebd4e20a57068663fed5960c4067ebc9d1579 as we can use core.BillingStart() |
mpalmi
pushed a commit
that referenced
this pull request
Jul 26, 2024
* add NormalizeToYear function and test * add ent changelog * test name typo (cherry picked from commit 01f78f5)
mpalmi
added a commit
that referenced
this pull request
Jul 26, 2024
* Prepare CE changes for [census.Agent] SetMetadata (#27577) (cherry picked from commit 93682b0) * Add CE plumbing for CensusManager reload (#27664) This PR adds the CE plumbing and stubs for forcing agent instantiation whenever the Vault license changes. Resolves: VAULT-28583 Enterprise PR: hashicorp/vault-enterprise#6168 (cherry picked from commit 3229cf1) * Add auto-roll billing start date changes CE changes (#27656) * add NormalizeToYear function and test * add ent changelog * test name typo (cherry picked from commit 01f78f5) --------- Co-authored-by: akshya96 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What does this PR do?
Adding CE changes for ENT PR https://github.com/hashicorp/vault-enterprise/pull/5681/files that auto-rolls billing start date.
JIRA: https://hashicorp.atlassian.net/browse/VAULT-24059
TODO only if you're a HashiCorp employee
getting backported to N-2, use the new style
backport/ent/x.x.x+entlabelsinstead of the old style
backport/x.x.xlabels.the normal
backport/x.x.xlabel (there should be only 1).of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.