Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimal Vault with few storage options and plugins #27394

Merged
merged 18 commits into from
Jun 12, 2024

Conversation

thyton
Copy link
Contributor

@thyton thyton commented Jun 6, 2024

This PR implements go build tag minimal build minimal Vault to control built-in plugin registry and storage options

  • Storage options available in minimal Vault
    • inmem_ha
    • inmem_transactional_ha
    • inmem_transactional
    • inmem
    • raft
  • Built-in plugins available in minimal Vault
    • auth
      • approle
      • cert
      • jwt
      • oidc
      • userpass
    • secret
      • kv
      • pki
      • ssh
      • transit
      • database
# build minimal Vault without UI
$ MINIMAL=1 make dev

# build minimal Vault with UI
$ MINIMAL=1 make static-dist make dev-ui 

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 6, 2024
Copy link

github-actions bot commented Jun 6, 2024

CI Results:
All required Go tests succeeded but failures were detected ⚠️
Failures:

Test Type Package Test Logs
race command TestAuditDisableCommand_Run view test results
race command TestAuditEnableCommand_Run view test results
race command TestAuditListCommand_Run view test results
race command TestAuthCommand_Run view test results
race command TestAuthDisableCommand_Run view test results
race command TestAuthDisableCommand_Run/integration view test results
race command TestAuthDisableCommand_Run/validations view test results
race command TestAuthEnableCommand_Run view test results
race command TestAuthHelpCommand_Run view test results
race command TestAuthListCommand_Run view test results

and 111 - 10 other tests

Copy link

github-actions bot commented Jun 6, 2024

Build Results:
All builds succeeded! ✅

@thyton thyton force-pushed the VAULT-27576-minimal-go-build-tag branch from 322bff3 to c29d10e Compare June 6, 2024 23:30
@thyton thyton requested review from fairclothjm and benashz June 6, 2024 23:32
Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

helper/builtinplugins/registry_full.go Outdated Show resolved Hide resolved
helper/builtinplugins/registry_min.go Outdated Show resolved Hide resolved
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Are there any tests that we can add to ensure that the vault-min was built properly? Maybe the same for vault-"mega", but might not be an issue.

helper/builtinplugins/registry_min.go Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@thyton thyton force-pushed the VAULT-27576-minimal-go-build-tag branch from 11ee56a to ed814c1 Compare June 10, 2024 15:18
changelog/27394.txt Outdated Show resolved Hide resolved
@thyton thyton force-pushed the VAULT-27576-minimal-go-build-tag branch from 898b100 to 878edb0 Compare June 10, 2024 18:38
@thyton thyton requested review from benashz and fairclothjm June 10, 2024 19:34
@thyton thyton enabled auto-merge (squash) June 12, 2024 16:40
@thyton thyton merged commit 83111c0 into main Jun 12, 2024
81 of 83 checks passed
@thyton thyton deleted the VAULT-27576-minimal-go-build-tag branch June 12, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants