Allow cert auth login attempts if ocsp_fail_open is true and servers are unreachable #25982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevendpclark
added
bug
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
sgmiller
approved these changes
Mar 18, 2024
| }) | ||
| } | ||
| goodTs := httptest.NewServer(ocspHandler(ocsp.Good)) | ||
| revokeTs := httptest.NewServer(ocspHandler(ocsp.Revoked)) |
| require.NoError(t, err, "failed parsing certificate from file %s", certFile) | ||
|
|
||
| return caTLS | ||
| } |
There was a problem hiding this comment.
Awesome tests. Much thorough, wow.
stevendpclark
force-pushed
the
stevendpclark/vault-24614-ocsp-no-nextupdate
branch
from
ddc3903 to
929d092
Compare
Base automatically changed from
stevendpclark/vault-24614-ocsp-no-nextupdate
to
main
March 18, 2024 22:12
stevendpclark
force-pushed
the
stevendpclark/vault-24316-ocsp-fail-open
branch
from
cb053c6 to
2c9f681
Compare
…ervers are unreachable
stevendpclark
force-pushed
the
stevendpclark/vault-24316-ocsp-fail-open
branch
from
2c9f681 to
fcf73eb
Compare
This was referenced Mar 19, 2024
stevendpclark
added a commit
that referenced
this pull request
Mar 19, 2024
…ervers are unreachable (#25982)
stevendpclark
added a commit
that referenced
this pull request
Mar 19, 2024
…ervers are unreachable (#25982) (#26029) Co-authored-by: Steven Clark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the cert auth had the role property ocsp_fail_open set to true, when network errors occurred, the errors would bubble up and prevent login attempts.
The error would look something like this:
ocsp_max_retriesconfig was added to allow easier testing of these use cases