Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: adds plugin identity token to enable and tune commands for secret engines and auth methods #24980

Merged
merged 7 commits into from
Jan 23, 2024
Merged

cli: adds plugin identity token to enable and tune commands for secret engines and auth methods #24980

merged 7 commits into from
Jan 23, 2024

Conversation

austingebauer
Copy link
Contributor

@austingebauer austingebauer commented Jan 22, 2024 •
edited
Loading

This PR adds the -identity-token-key flag to the Vault CLI for enable and tune of secret engines and auth methods.

Depends on #24962 being merged first.

@austingebauer austingebauer added this to the 1.16.0-rc1 milestone Jan 22, 2024
@austingebauer austingebauer requested a review from a team January 22, 2024 16:59
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jan 22, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2024 •
edited
Loading

CI Results:
All Go tests succeeded! ✅

@github-actions GitHub Actions
Copy link

Build Results:
All builds succeeded! ✅

vinay-gopalan
vinay-gopalan approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@austingebauer austingebauer merged commit a93ee17 into main Jan 23, 2024
110 checks passed
@austingebauer austingebauer deleted the cli/identity-token-key branch January 23, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinay-gopalan vinay-gopalan vinay-gopalan approved these changes

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Milestone
1.16.0-rc1
Development

Successfully merging this pull request may close these issues.
2 participants
@austingebauer @vinay-gopalan