VAULT-22569: Handle nil node info when retrieving HA peers #24441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
miagilepner
force-pushed
the
miagilepner/panic-node-info
branch
from
00821a9 to
d9ab24a
Compare
|
Build Results: |
|
CI Results: |
mpalmi
approved these changes
Dec 8, 2023
jpenghashi
added a commit
that referenced
this pull request
Dec 8, 2023
Due to the reported issue under #24441, we identified that there are users issuing step-down during the upgrade, which is unintended. We modified the documentation to make it clear that step-down should not be attempted, in addition rephrased the sentence with "step-down" word and exclude that term to avoid confusion.
schavis
pushed a commit
that referenced
this pull request
May 1, 2024
Due to the reported issue under #24441, we identified that there are users issuing step-down during the upgrade, which is unintended. We modified the documentation to make it clear that step-down should not be attempted, in addition rephrased the sentence with "step-down" word and exclude that term to avoid confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24419
Starting in 1.10 we added a new field to the
EchoRequestcalledNodeInfo. This field gets accessed without a nil check inGetHAPeerNodesCached, which is called by the undo logs watcher.