Address a panic when exporting RSA public keys in transit #24054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stevendpclark
commented
Nov 7, 2023
stevendpclark
commented
- When attempting to export the public key for an RSA key that we only have a private key for, the export panics with a nil deference.
- Add additional tests around Transit key exporting
- Fixes Exporting RSA public keys via transit/export/public-key/<key-name>/<version> causes nil dereference crash #23980
- When attempting to export the public key for an RSA key that we only have a private key for, the export panics with a nil deference. - Add additional tests around Transit key exporting
stevendpclark
added
bug
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
|
CI Results: |
stevendpclark
deleted the
stevendpclark/vault-21677-transit-export-rsa-panic
branch
This was referenced Nov 14, 2023
Merged
stevendpclark
added a commit
that referenced
this pull request
Nov 14, 2023
* Address a panic export RSA public keys in transit - When attempting to export the public key for an RSA key that we only have a private key for, the export panics with a nil deference. - Add additional tests around Transit key exporting * Add cl
stevendpclark
added a commit
that referenced
this pull request
Nov 14, 2023
…24116) * Address a panic export RSA public keys in transit - When attempting to export the public key for an RSA key that we only have a private key for, the export panics with a nil deference. - Add additional tests around Transit key exporting * Add cl Co-authored-by: Steven Clark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.