Custom tooltip for Generated Token Policies form field on auth methods #15046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashishaw
suggested changes
Apr 14, 2022
ui/app/components/generated-item.js
Outdated
| // HelpText from the backend says add a comma separated list, which works on the CLI but not here on the UI. | ||
| // This effects TLS Certificates, Userpass, and Kubernetes. https://github.com/hashicorp/vault/issues/10346 | ||
| if (element.Tokens) { | ||
| element.Tokens.forEach((attr) => { |
There was a problem hiding this comment.
Instead of iterating over all of them can we do element.Tokens.find(attr => attr.name === 'tokenPolicies') and then update it if found? That way iteration will stop once the item is found, or have the same behavior as iterating over each if not found
There was a problem hiding this comment.
Great idea. Amending.
| @@ -69,6 +70,18 @@ module('Acceptance | auth backend list', function (hooks) { | |||
| await triggerKeyEvent('[data-test-input="username"]', 'keyup', 65); | |||
| await fillIn('[data-test-textarea]', user2); | |||
| await triggerKeyEvent('[data-test-textarea]', 'keyup', 65); | |||
| // test for modified helpText on generated token policies | |||
| await click('[data-test-toggle-group="Tokens"]'); | |||
This was referenced Apr 14, 2022
kitography
pushed a commit
that referenced
this pull request
Apr 24, 2022
#15046) * the conditional fix * add test coverage * changelog * add possesive * fix language * fix * fix * change quotes * fix * replace with find
schultz-is
pushed a commit
that referenced
this pull request
Apr 27, 2022
#15046) * the conditional fix * add test coverage * changelog * add possesive * fix language * fix * fix * change quotes * fix * replace with find
schultz-is
pushed a commit
that referenced
this pull request
May 2, 2022
#15046) * the conditional fix * add test coverage * changelog * add possesive * fix language * fix * fix * change quotes * fix * replace with find
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intercepts the model on the
generatedItemcomponent to replace thehelpTextfor the auth form field "Generated Token's Policies"Before the help text read: Comma-separated list of policies associated with the user.
However, this field (e.g form field = stringArray) does not accept comma separated lists. We instead want a user to add a row for each new policy. We cannot change the text here because that changes the CLI text which does accept a comma separated list. So instead, we interrupt the component, search for this field type and replace the helpText with the following: Add policies that will apply to the generated token for this user. One policy per row.
This now looks like this:
This change effects TLS Certificates, Userpass, and Kubernetes who have this field. The other auth methods have a different field or no policy field at all.
Will backport to 1.8
See GH issue here.