UI: Masked inputs always look the same when value is hidden #15025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zofskeez
approved these changes
Apr 13, 2022
This was referenced Apr 13, 2022
Closed
Closed
hashishaw
added a commit
that referenced
this pull request
Apr 13, 2022
* Masked inputs always look the same when value is hidden * Add changelog * Fix failing test
hashishaw
added a commit
that referenced
this pull request
Apr 13, 2022
* Masked inputs always look the same when value is hidden * Add changelog * Fix failing test
hashishaw
added a commit
that referenced
this pull request
Apr 13, 2022
* Masked inputs always look the same when value is hidden * Add changelog * Fix failing test
This was referenced Apr 13, 2022
hashishaw
added a commit
that referenced
this pull request
Apr 14, 2022
kitography
pushed a commit
that referenced
this pull request
Apr 24, 2022
* Masked inputs always look the same when value is hidden * Add changelog * Fix failing test
schultz-is
pushed a commit
that referenced
this pull request
Apr 27, 2022
* Masked inputs always look the same when value is hidden * Add changelog * Fix failing test
schultz-is
pushed a commit
that referenced
this pull request
May 2, 2022
* Masked inputs always look the same when value is hidden * Add changelog * Fix failing test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this fix, if a masked value had special characters such as é, à, è the masked value would give away where chose characters are in the string.
After this fix, masked display will be completely agnostic to the actual value -- always showing the same length and size of character. This PR addresses issue 13270
Before - you can tell without showing the value where the special character is
After - can no longer tell when masked the length or location of special characters
It's worth noting that the input will still show the true length and location of the special character. This is so that the user can type in the field without unmasking the value.
