Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Enigma Vault secret plugin to community plugin list #14389

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

ixe013
Copy link
Contributor

@ixe013 ixe013 commented Mar 7, 2022

Designed to be simple but complete, this Enigma machine as a Vault plugin is a good starting point for plugin developers, including:

  1. The build environment
  2. Code organization
  3. Your first function
  4. Debugging
  5. Unit testing
  6. Accepting parameters
  7. Different paths for different purposes
  8. Persist state and secrets
  9. Upgrading your plugin

@ixe013 ixe013 requested review from taoism4504 and acahn as code owners March 7, 2022 17:06
@ixe013 ixe013 force-pushed the New-Enigma-Secret-Engine-Plugin branch 2 times, most recently from 873768c to 9a58c9c Compare March 7, 2022 17:29
@ixe013
Copy link
Contributor Author

ixe013 commented Mar 7, 2022

I approved the Vercel deployment, but it did not unblock the pipeline...

@cipherboy
Copy link
Contributor

FWIW it appears the PR is blocked by test-go actually:

Failed
=== RUN   TestRateLimitQuota_Allow
    quotas_rate_limit_test.go:121: 
        	Error Trace:	quotas_rate_limit_test.go:121
        	Error:      	Should not be zero, but was 0
        	Test:       	TestRateLimitQuota_Allow
        	Messages:   	expected some requests to fail; addr: 127.0.0.1, numSuccess: 78, numFail: 0, elapsed: 5011117732
--- FAIL: TestRateLimitQuota_Allow (5.01s)

I've triggered a rerun for you in CircleCI as it appears unrelated.

@heatherezell
Copy link
Contributor

Hi there @ixe013! Thank you for this submission. It prompted an internal discussion around how we want to handle community-contributed plugins, and as a result we updated the plugin development page via #14414. Would you be willing to update this PR accordingly, so we can get this published? Thanks so much for this, it's a great example! :)

… a good starting point for plugin developers
@ixe013 ixe013 force-pushed the New-Enigma-Secret-Engine-Plugin branch from 9a58c9c to 1096f90 Compare March 11, 2022 02:47
@ncabatoff ncabatoff merged commit 785aff9 into hashicorp:main Mar 11, 2022
@ncabatoff
Copy link
Collaborator

Thanks @ixe013 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants