Adds missing unlock of RWMutex in OIDC delete key #12916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austingebauer
requested review from
vinay-gopalan,
jasonodonnell,
calvn and
fairclothjm
jasonodonnell
approved these changes
Oct 25, 2021
calvn
approved these changes
Oct 25, 2021
austingebauer
added a commit
that referenced
this pull request
Oct 25, 2021
austingebauer
added a commit
that referenced
this pull request
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing calls to
Unlock()in error handling blocks ofpathOIDCDeleteKey(). This ensures that other goroutines can eventually acquire the lock after the errors occur.Note that I'm adding a changelog entry to this PR because the bug was partially released in 1.8.1 (see identity_store_oidc.go#L635-L638). I plan to backport this into
release/1.8.xand remove the OIDC provider related call toclientNamesReferencingTargetKeyName().