Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed overflowing text of flash message container #12357

Merged
merged 2 commits into from
Aug 19, 2021
Merged

Fixed overflowing text of flash message container #12357

merged 2 commits into from
Aug 19, 2021

Conversation

arnav28
Copy link
Contributor

@arnav28 arnav28 commented Aug 19, 2021

No description provided.

@arnav28
Copy link
Contributor Author

arnav28 commented Aug 19, 2021

Screen Shot 2021-08-18 at 5 48 28 PM

@vercel vercel bot temporarily deployed to Preview – vault August 19, 2021 00:50 Inactive
@arnav28 arnav28 added the ui label Aug 19, 2021
@vercel vercel bot temporarily deployed to Preview – vault-storybook August 19, 2021 00:58 Inactive
Monkeychip
Monkeychip approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, same as before, unsure if this should be backported, and if so change the milestone to whatever version we're backporting to.

@arnav28 arnav28 merged commit 8399fb2 into main Aug 19, 2021
@arnav28
Copy link
Contributor Author

arnav28 commented Aug 19, 2021

Nice work, same as before, unsure if this should be backported, and if so change the milestone to whatever version we're backporting to.

I don't think backport is needed, it's very minor and edge case (text only overflows when the text is super long).

@arnav28 arnav28 deleted the ui/flash-message-overflow branch August 19, 2021 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monkeychip Monkeychip Monkeychip approved these changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arnav28 @Monkeychip