-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vault 0.10.0 is flooding Consul backend with GET /v1/kv/vault/sys/token/parent/xxxxxxx/?keys=&separator=%2F requests (3K RPS) #4462
Comments
I think this is due to a previous error fixed by 0.10 in #4193. Can you try running auth/token/tidy on 0.10? |
@jefferai could you please elaborate what I should do? |
Yep, run this: https://www.vaultproject.io/api/auth/token/index.html#tidy-tokens From a Vault CLI you could do |
Thanks! Next working day for me is Sunday, so I'll do it then. |
Question for you: do you issue a lot of child tokens (and potentially have them then issue a lot of child tokens)? We think what's happening is that you have one parent token with a huge subtree underneath it of tokens that then need to be revoked because of the parent token being revoked. We found a place where we're not being super efficient at revocation time, which can halve the number of GET requests that are made (see #4465) but it will only make things better...the root cause is still the question, and it seems like you just have a huge token hierarchy that is being revoked. |
Sure I do! |
If those are not orphan tokens, you are correct. We recommend issuing orphan tokens for this exact reason. So likely all of these requests are because of Vault chewing through all of the revocations. If you want to build from source you can try pulling in #4465 which will remove the need for some requests and help a bit. |
Thanks, I'll check how to make nomad issue orphaned tokens for jobs |
See https://www.nomadproject.io/docs/vault-integration/index.html for a detailed guide. |
I ran the command you provided @jefferai, but unfortunately, I think there is a bug, cause Vault/Consul is on high CPU for more than 48 hours already.
any hints? |
I think it's likely the same issue as #4143, can you subscribe to that one? |
looks like the same. I think it's better to close it as duplicate |
Will do. Duplicate of #4143 |
Environment:
Vault Version:
Vault v0.10.0 ('5dd7f25f5c4b541f2da62d70075b6f82771a650d')
Operating System/Architecture:
Vault Config File:
Expected Behavior:
Not flood the backend
Actual Behavior:
Vault is sending thousands of requests to backend causing both vault and consul to have very high CPU
consul monitor with debug level output:
Steps to Reproduce:
update to 0.10.0
The text was updated successfully, but these errors were encountered: