Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log warnings when too many leases are active #3903

Closed
armon opened this issue Feb 3, 2018 · 1 comment
Closed

Log warnings when too many leases are active #3903

armon opened this issue Feb 3, 2018 · 1 comment
Milestone

Comments

@armon
Copy link
Member

armon commented Feb 3, 2018

Feature Request:

We should issue a warning in the log message when too many leases are active in the system. This is usually an indication that the rate in (new leases) does not match rate out (expiration / revocation) and will eventually lead to cluster degradation or failure.

Conservatively, we could use a high warning threshold like 256K leases, which is unlikely to ever be a reasonable steady state. This could potentially be made a tunable knob if necessary.

This is where the metric is currently emitted, might be good to restrict logging to once every N interval to avoid flooding.

metrics.SetGauge([]string{"expire", "num_leases"}, float32(num))

@jefferai
Copy link
Member

Closed by #3957

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants