Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support cidr restrictions for userpass auth #1175

Closed
cburroughs opened this issue Mar 4, 2016 · 6 comments
Closed

support cidr restrictions for userpass auth #1175

cburroughs opened this issue Mar 4, 2016 · 6 comments

Comments

@cburroughs
Copy link

I'd also like to support cidr restrictions for userpass auth. Examples:

  • Corp network binds employees workstation IP to a known value, employee X password should not work from employee Y's workstation.
  • Database X credentials should not be accessed from datacenter Y
  • Only auth to service X from a bastion, so only the bastion needs the credentials.

I'm aware that this is an "in depth" approach and not foolproof. #815 is very similar (for tokens) but I didn't see anything specifically for userpass

@jefferai
Copy link
Member

jefferai commented Mar 4, 2016

I think this is a totally fine request but will probably end up waiting until we support X-Real-IP and or other similar methods of trying to identify the correct IP address. But, if someone picks it up before then, I'll be happy to work with them on getting it integrated.

@jefferai jefferai added this to the future milestone Mar 4, 2016
@pearkes pearkes closed this as completed Apr 19, 2016
@jefferai jefferai reopened this Apr 19, 2016
@v6
Copy link
Contributor

v6 commented May 3, 2018

// , @cburroughs , would I really need to use this if I already had https://www.vaultproject.io/docs/auth/cert.html ?

That is, if I already have https://www.vaultproject.io/docs/auth/cert.html, would it be worth adding CIDR based restrictions to my user/pass auth?

@v6
Copy link
Contributor

v6 commented May 3, 2018

// , Also, why doesn't Vault have a more generic use of CIDR restrictions? That is, if you can CIDR restrict one thing, why can't you CIDR restrict another?

@tyrannosaurus-becks
Copy link
Contributor

@cburroughs - I just merged in this capability, FYI!

@v6
Copy link
Contributor

v6 commented May 21, 2018

// , Can I get a quick link to the PR

@tyrannosaurus-becks
Copy link
Contributor

@v6 #4557

@pbernal pbernal removed this from the not-scheduled milestone May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants