-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support cidr restrictions for userpass auth #1175
Comments
I think this is a totally fine request but will probably end up waiting until we support X-Real-IP and or other similar methods of trying to identify the correct IP address. But, if someone picks it up before then, I'll be happy to work with them on getting it integrated. |
// , @cburroughs , would I really need to use this if I already had https://www.vaultproject.io/docs/auth/cert.html ? That is, if I already have https://www.vaultproject.io/docs/auth/cert.html, would it be worth adding CIDR based restrictions to my user/pass auth? |
// , Also, why doesn't Vault have a more generic use of CIDR restrictions? That is, if you can CIDR restrict one thing, why can't you CIDR restrict another? |
@cburroughs - I just merged in this capability, FYI! |
// , Can I get a quick link to the PR |
I'd also like to support cidr restrictions for userpass auth. Examples:
I'm aware that this is an "in depth" approach and not foolproof. #815 is very similar (for tokens) but I didn't see anything specifically for userpass
The text was updated successfully, but these errors were encountered: