From 87f09c8b84860217af937ffc0498dc871c5385d4 Mon Sep 17 00:00:00 2001
From: Chelsea Shaw <82459713+hashishaw@users.noreply.github.com>
Date: Wed, 15 Nov 2023 16:18:53 -0600
Subject: [PATCH] UI: Allow token configuration tune from namespace (#24147)

* check methodType instead of type when checking to remove token_type from payload

* Add changelog
---
 changelog/24147.txt                           |  3 +++
 ui/app/components/auth-config-form/options.js |  2 +-
 ui/tests/acceptance/auth-list-test.js         | 16 ++++++++++++++++
 3 files changed, 20 insertions(+), 1 deletion(-)
 create mode 100644 changelog/24147.txt

diff --git a/changelog/24147.txt b/changelog/24147.txt
new file mode 100644
index 000000000000..960ae2250ca4
--- /dev/null
+++ b/changelog/24147.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+ui: Fix error when tuning token auth configuration within namespace
+```
\ No newline at end of file
diff --git a/ui/app/components/auth-config-form/options.js b/ui/app/components/auth-config-form/options.js
index c0e7f98326a9..38b6da115aa1 100644
--- a/ui/app/components/auth-config-form/options.js
+++ b/ui/app/components/auth-config-form/options.js
@@ -32,7 +32,7 @@ export default AuthConfigComponent.extend({
       data.description = this.model.description;
 
       // token_type should not be tuneable for the token auth method.
-      if (this.model.type === 'token') {
+      if (this.model.methodType === 'token') {
         delete data.token_type;
       }
 
diff --git a/ui/tests/acceptance/auth-list-test.js b/ui/tests/acceptance/auth-list-test.js
index 0ac6e53a8f06..9aa51b8cdee7 100644
--- a/ui/tests/acceptance/auth-list-test.js
+++ b/ui/tests/acceptance/auth-list-test.js
@@ -151,4 +151,20 @@ module('Acceptance | auth backend list', function (hooks) {
       }
     }
   });
+
+  test('enterprise: token config within namespace', async function (assert) {
+    const ns = 'ns-wxyz';
+    await runCmd(`write sys/namespaces/${ns} -f`);
+    await authPage.loginNs(ns);
+    // go directly to token configure route
+    await visit('/vault/settings/auth/configure/token/options');
+    await fillIn('[data-test-input="description"]', 'My custom description');
+    await click('[data-test-save-config="true"]');
+    assert.strictEqual(currentURL(), '/vault/access', 'successfully saves and navigates away');
+    await click('[data-test-auth-backend-link="token"]');
+    assert
+      .dom('[data-test-row-value="Description"]')
+      .hasText('My custom description', 'description was saved');
+    await runCmd(`delete sys/namespaces/${ns}`);
+  });
 });