Skip to content

Commit

Permalink
Disable key rotation when deleting a key (#10)
Browse files Browse the repository at this point in the history
* Disable key rotation on key delete

* Deps update
  • Loading branch information
sethvargo authored and briankassouf committed May 16, 2019
1 parent 103b748 commit 88f9a4f
Show file tree
Hide file tree
Showing 6 changed files with 121 additions and 81 deletions.
4 changes: 2 additions & 2 deletions backend_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ func testKMSKeyRingName(tb testing.TB, name string) string {
}

if name == "" {
name = fmt.Sprintf("vault-test-%s", uuid.Must(uuid.NewV4()))
name = fmt.Sprintf("vault-test-%s", uuid.NewV4())
}

return fmt.Sprintf("projects/%s/locations/us-east1/keyRings/%s", project, name)
Expand Down Expand Up @@ -162,7 +162,7 @@ func testCreateKMSCryptoKeyPurpose(tb testing.TB, purpose kmspb.CryptoKey_Crypto
kmsClient := testKMSClient(tb)

keyRing, cleanup := testCreateKMSKeyRing(tb, "")
keyName := fmt.Sprintf("%s", uuid.Must(uuid.NewV4()))
keyName := fmt.Sprintf("%s", uuid.NewV4())

ctx := context.Background()

Expand Down
25 changes: 18 additions & 7 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,30 @@ module github.com/hashicorp/vault-plugin-secrets-gcpkms
go 1.12

require (
cloud.google.com/go v0.37.4
cloud.google.com/go v0.39.0
github.com/armon/go-radix v1.0.0 // indirect
github.com/gammazero/deque v0.0.0-20190130191400-2afb3858e9c7 // indirect
github.com/gammazero/workerpool v0.0.0-20190406235159-88d534f22b56
github.com/golang/protobuf v1.3.1
github.com/google/go-cmp v0.3.0 // indirect
github.com/hashicorp/errwrap v1.0.0
github.com/hashicorp/go-hclog v0.8.0
github.com/hashicorp/go-hclog v0.9.2
github.com/hashicorp/go-multierror v1.0.0
github.com/hashicorp/vault/api v1.0.1
github.com/hashicorp/vault/sdk v0.1.8
github.com/hashicorp/go-version v1.2.0 // indirect
github.com/hashicorp/vault/api v1.0.2
github.com/hashicorp/vault/sdk v0.1.10
github.com/jeffchao/backoff v0.0.0-20140404060208-9d7fd7aa17f2
github.com/kr/pretty v0.1.0 // indirect
github.com/mitchellh/go-homedir v1.1.0 // indirect
github.com/satori/go.uuid v1.2.0
golang.org/x/crypto v0.0.0-20190513172903-22d7a77e9e5f // indirect
golang.org/x/net v0.0.0-20190514140710-3ec191127204 // indirect
golang.org/x/oauth2 v0.0.0-20190402181905-9f3314589c9a
google.golang.org/api v0.3.2
google.golang.org/genproto v0.0.0-20190404172233-64821d5d2107
google.golang.org/grpc v1.20.0
golang.org/x/sys v0.0.0-20190514135907-3a4b5fb9f71f // indirect
golang.org/x/text v0.3.2 // indirect
google.golang.org/api v0.5.0
google.golang.org/appengine v1.6.0 // indirect
google.golang.org/genproto v0.0.0-20190513181449-d00d292a067c
google.golang.org/grpc v1.20.1
gopkg.in/check.v1 v1.0.0-20180628173108-788fd7840127 // indirect
)
Loading

0 comments on commit 88f9a4f

Please sign in to comment.