Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguity In List Roles Path - vault-plugin-auth-azure Versus Upstream Azure Auth Documentation #19

Open
jeffwecan opened this issue Feb 1, 2019 · 0 comments

Comments

@jeffwecan
Copy link

jeffwecan commented Feb 1, 2019

Within https://github.com/hashicorp/vault-plugin-auth-azure/blob/24c521e5d747a42fb2c746ddea23a6a183a146c3/path_role.go, the "List Roles" path appears to be defined as plain 'ole /role however the related https://github.com/hashicorp/vault documentation specifies a path of /azure/roles: https://github.com/hashicorp/vault/blob/068da60712ce8ccc260513b564bd862b110deadd/website/source/api/secret/azure/index.html.md#list-roles.

I'm happy to make a PR to one of these two code bases to true up the matter. However I would be interested to hear from the maintainers here on the background context. I.e., is LIST request to the /azure/role path the intended specification (in which case we can update the Vault repository's docs) or is the documentation accurately capturing the intended path (in which case, the path_role.go source within this codebase should presumably be updated to match the path listed within https://github.com/hashicorp/vault's documentation).

@jeffwecan jeffwecan changed the title Ambiguity In List Roles Path Ambiguity In List Roles Path - vault-plugin-auth-azure Versus Upstream Azure Auth Documentation Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant