expand regex to allow underscores (and periods) #172
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands the "nameRx" - used for vm names and vmss names to allow underscores and periods. Disallows periods and hyphens from being the last character, as described by https://azure.github.io/PSRule.Rules.Azure/en/rules/Azure.VM.Name/#description
I also added parens to resource group names, since they seem to be allowed both in https://azure.github.io/PSRule.Rules.Azure/en/rules/Azure.ResourceGroup.Name/ and https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/resource-name-rules (grep for 'resourcegroup')
I am open to kibitzing on if we should just simplify the regexen to block slashes specifically.